Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect variable binding type when printing #1939

Merged
merged 1 commit into from Sep 28, 2022

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Sep 28, 2022

Closes #1750

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3142482448/npm-package-wrangler-1939

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1939/npm-package-wrangler-1939

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3142482448/npm-package-wrangler-1939 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.developers.workers.dev/runs/3142482448/npm-package-cloudflare-pages-shared-1939

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #1939 (fde3bee) into main (7ebaec1) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1939      +/-   ##
==========================================
- Coverage   75.22%   75.11%   -0.11%     
==========================================
  Files         116      116              
  Lines        7907     7929      +22     
  Branches     2057     2065       +8     
==========================================
+ Hits         5948     5956       +8     
- Misses       1959     1973      +14     
Impacted Files Coverage Δ
packages/wrangler/src/config/index.ts 92.30% <100.00%> (+0.55%) ⬆️
packages/wrangler/src/proxy.ts 16.58% <0.00%> (-1.27%) ⬇️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

@rozenmd rozenmd merged commit 5854cb6 into main Sep 28, 2022
@rozenmd rozenmd deleted the print-bindings-correctly branch September 28, 2022 09:53
@github-actions github-actions bot mentioned this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Variable bindings that aren't strings are rendered incorrectly
2 participants