New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: error if d1 bindings used with no-bundle
#1955
Conversation
🦋 Changeset detectedLatest commit: 6e46562 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3151349412/npm-package-wrangler-1955 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1955/npm-package-wrangler-1955 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/3151349412/npm-package-wrangler-1955 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.developers.workers.dev/runs/3151349412/npm-package-cloudflare-pages-shared-1955 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1955 +/- ##
=======================================
Coverage 74.96% 74.96%
=======================================
Files 116 116
Lines 7952 7958 +6
Branches 2074 2078 +4
=======================================
+ Hits 5961 5966 +5
- Misses 1991 1992 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
While in beta, you cannot use D1 bindings without bundling your worker as these are added in through a facade which gets bypassed when using the
no-bundle
option.This will be removed once the bindings are no longer needing to be added using a shim.
Closes #1954