Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Emoji space in help description #1964

Merged
merged 1 commit into from Sep 30, 2022

Conversation

JacobMGEvans
Copy link
Contributor

Added a space between the Emoji and description for the secret:bulk command.

Added a space between the Emoji and description for the secret:bulk command.
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

🦋 Changeset detected

Latest commit: e401e58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3153565224/npm-package-wrangler-1964

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1964/npm-package-wrangler-1964

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3153565224/npm-package-wrangler-1964 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.developers.workers.dev/runs/3153565224/npm-package-cloudflare-pages-shared-1964

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1964 (e401e58) into main (fface9f) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
+ Coverage   74.95%   74.96%   +0.01%     
==========================================
  Files         116      116              
  Lines        7958     7958              
  Branches     2078     2078              
==========================================
+ Hits         5965     5966       +1     
+ Misses       1993     1992       -1     
Impacted Files Coverage Δ
packages/wrangler/src/index.tsx 89.16% <ø> (ø)
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

Copy link
Contributor

@cameron-robey cameron-robey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but interested to know why the number of spaces is not being respected by yargs and hence we need 2 spaces for some, and 1 for others - is it to do with some emoji taking different numbers of characters in monospace fonts?

@JacobMGEvans JacobMGEvans merged commit 1f50578 into main Sep 30, 2022
@JacobMGEvans JacobMGEvans deleted the jacobmgevans/fix-emoji-help branch September 30, 2022 14:04
@JacobMGEvans
Copy link
Contributor Author

Approving, but interested to know why the number of spaces is not being respected by yargs and hence we need 2 spaces for some, and 1 for others - is it to do with some emoji taking different numbers of characters in monospace fonts?

Not sure to be honest, but I saw the lack of space and noticed the snapshots were deceptively close to looking correct lol

@github-actions github-actions bot mentioned this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants