Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health-check-type is ignored from manifest.yml when pushing application #108

Open
ivankoster opened this issue Nov 12, 2020 · 1 comment

Comments

@ivankoster
Copy link

When using the pushoperation health-check-type and related fields are ignored from a manifest file.
This is caused by the v2 api of cf using the same field names, but the dashes are converted to underscores.

The fields with dashes are dropped in _generate_application_update_request in apps.py because AppManager.APPLICATION_FIELDS does not contain them, but the underscored versions.

@antechrestos
Copy link
Member

@ivankoster Hi. I am not sure I understand very well. You mean that

  • manifest could contain health-check-type or health-check-http-endpoint
  • if provided, set application attribute to health_check_type and or health-check-http-endpoint

Is that so? Would you like provide a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants