Design/error alert #1937
Merged
Design/error alert #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 141bccf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tylersticka
reviewed
Jul 12, 2022
tylersticka
reviewed
Jul 18, 2022
Co-authored-by: Tyler Sticka <tyler@cloudfour.com>
Edit changeset message Move content around Delete comments in json file
tylersticka
previously approved these changes
Jul 19, 2022
tylersticka
approved these changes
Jul 19, 2022
This was referenced Jul 19, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR:
sad-emojito correspond with the Error alertI've added a TODO, I don't wanna bug a developer when we're so close to launch. I'm going to create an issue to make the icon and color change automatic, instead of just the color when the class is applied. I don't know how to do that. Or, I can convert this PR to a draft and come back to it when a dev is more available.
Screenshots
Color design tokens:
Error alert:
Icon:
Testing