Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider matching DOM order for Sky Nav elements when JS is disabled for better accessibility #1994

Open
gerardo-rodriguez opened this issue Aug 2, 2022 · 2 comments
Labels
🦮 a11y Accessibility improvements 🎨 design Requires visual, UX or UI design decisions ⁉️ question Further information is requested

Comments

@gerardo-rodriguez
Copy link
Member

gerardo-rodriguez commented Aug 2, 2022

When JS is disabled:

  • the "Menu" button is hidden
  • the Sky Nav is open

Current implementation

The DOM order of the nav does not match the visual order in the current solution:

Current tab order count Current tab order in action
Screen Shot 2022-08-02 at 9 39 01 AM source-order-current

Proposed solution

We should consider allowing the visual order to match the DOM order when JS is disabled. We might even consider centering the Cloud Four logo since the button is not shown:

Proposes tab order count Proposed tab order in action
Screen Shot 2022-08-02 at 9 46 09 AM source-order-proposal

Other considerations

  • The gradient no longer matches the original design in the proposed solution

Related

@gerardo-rodriguez gerardo-rodriguez added ⁉️ question Further information is requested 🎨 design Requires visual, UX or UI design decisions 🦮 a11y Accessibility improvements labels Aug 2, 2022
@gerardo-rodriguez gerardo-rodriguez changed the title Consider matching DOM order for Sky Nav elements when JS is disabled Consider matching DOM order for Sky Nav elements when JS is disabled for better accessibility Aug 2, 2022
@gerardo-rodriguez gerardo-rodriguez self-assigned this Sep 13, 2022
@gerardo-rodriguez
Copy link
Member Author

gerardo-rodriguez commented Sep 13, 2022

@tylersticka I'm going to proceed with the following when JS is disabled:

  • Change flex-direction: column-reverse to flex-direction: column
  • Center the the Cloud Four logo (since the menu toggle button is not available)

Would you like me to explore shifting the CSS gradient around as well so that it transitions smoothly from the top (cloud four logo) to the bottom of the nav link list?

Thank you!

@tylersticka
Copy link
Member

@gerardo-rodriguez Can you hold on this one for now until we have a mockup?

@gerardo-rodriguez gerardo-rodriguez removed their assignment Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦮 a11y Accessibility improvements 🎨 design Requires visual, UX or UI design decisions ⁉️ question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants