Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore updates to our fluid type calculations for simplicity and accessibility #2128

Open
tylersticka opened this issue Feb 7, 2023 · 0 comments
Labels
🦮 a11y Accessibility improvements 👷 dev 🎨 design Requires visual, UX or UI design decisions ✨ enhancement New feature or request

Comments

@tylersticka
Copy link
Member

Overview

We last refactored our fluid type calculations in 2021 (#1560), but since then there's been more research and development on the topic.

Our current calculations seem to be working well, but there may be an accessibility issue with the negative number in the calculations.

Some more recent calculators do not seem to rely on negative calculations:

We may want to test our fluid type more thoroughly, and possibly revisit our mixin to see if we can generate something even nicer.

@tylersticka tylersticka added ✨ enhancement New feature or request 🎨 design Requires visual, UX or UI design decisions 🦮 a11y Accessibility improvements 👷 dev labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦮 a11y Accessibility improvements 👷 dev 🎨 design Requires visual, UX or UI design decisions ✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant