Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change document title from "Storybook" to "Cloud Four Patterns" #536

Open
spaceninja opened this issue Mar 9, 2020 · 3 comments
Open

Change document title from "Storybook" to "Cloud Four Patterns" #536

spaceninja opened this issue Mar 9, 2020 · 3 comments
Labels
✋ blocked Can't proceed quite yet 👷 environment Setup, build tools, configuration, etc.

Comments

@spaceninja
Copy link
Member

Unfortunately, there is currently no mechanism to do so. This used to be supported via the now-deprecated addon-options.

There's a lengthy, ongoing, open issue, and several other closed issues regarding this topic. I tried every solution in storybookjs/storybook#866 but none of them work — there's a bit of React logic happening that immediately resets the document title to "Storybook" after a second.

For now, this ticket is not actionable, but we should keep an eye on that ticket and apply a solution when one exists.

@spaceninja spaceninja added the 👷 environment Setup, build tools, configuration, etc. label Mar 9, 2020
@tylersticka tylersticka added this to 🔙 Backlog in cloudfour.com-patterns@next via automation Mar 11, 2020
@tylersticka tylersticka removed this from 🔙 Backlog in cloudfour.com-patterns@next Mar 11, 2020
@tylersticka
Copy link
Member

This is now possible in Storybook 6.5.0, but since we haven't updated to that yet I'm marking this as blocked.

@tylersticka tylersticka added the ✋ blocked Can't proceed quite yet label May 24, 2022
@tylersticka tylersticka removed the ✋ blocked Can't proceed quite yet label Jun 21, 2022
@tylersticka
Copy link
Member

We have updated to Storybook 6.5.x, so this should not be blocked anymore.

@tylersticka tylersticka added this to 🔙 Backlog in cloudfour.com-patterns@next via automation Jun 21, 2022
@tylersticka
Copy link
Member

I think there was a misunderstanding in that issue of what the request was. I still think this isn't possible without hackery until storybookjs/storybook#14726 is resolved.

Marking as blocked again.

@tylersticka tylersticka removed this from 🔙 Backlog in cloudfour.com-patterns@next Jun 27, 2022
@tylersticka tylersticka added the ✋ blocked Can't proceed quite yet label Jun 27, 2022
@tylersticka tylersticka removed the size:? label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋ blocked Can't proceed quite yet 👷 environment Setup, build tools, configuration, etc.
Projects
None yet
Development

No branches or pull requests

2 participants