Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated fields from logging #2206

Closed
mnencia opened this issue Jun 6, 2023 · 0 comments · Fixed by #4223
Closed

Remove duplicated fields from logging #2206

mnencia opened this issue Jun 6, 2023 · 0 comments · Fixed by #4223
Assignees
@sxd

Comments

@mnencia
Copy link
Member

mnencia commented Jun 6, 2023

Since controller-runtime 0.12, the logger in the request context already has the reconcileID field containing a unique identified of the request. Also, the default LogConstructor adds the name and namespace to every line.

This change makes most of our https://github.com/cloudnative-pg/cloudnative-pg/blob/b87182bdfff4eefcb2d619f9296ffc8edd159c09/pkg/management/log/log.go redundant, and we should remove it.
@armru armru removed their assignment Jun 7, 2023
sxd added a commit that referenced this issue Apr 6, 2024
@sxd
chore: remove the UUID from the logs
e037393 
Since controller-runtime adds their own reconcileID, adding a uuid field
is not needed anymore

Closes #2206

Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
@sxd sxd mentioned this issue Apr 6, 2024
Merged
@sxd sxd self-assigned this Apr 6, 2024
leonardoce pushed a commit that referenced this issue Apr 6, 2024
@sxd @leonardoce
chore: remove the UUID from the logs
f6fc02f 
Since controller-runtime adds their own reconcileID, adding a uuid field
is not needed anymore

Closes #2206

Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
leonardoce pushed a commit that referenced this issue Apr 6, 2024
@sxd
chore: remove duplicate UUID from the logs (#4223)
9f552ba 
Since controller-runtime adds their own `reconcileID`, adding a uuid field
is not needed anymore.

Partially closes: #2206

Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
leonardoce pushed a commit that referenced this issue Apr 6, 2024
@sxd @leonardoce
chore: remove duplicate UUID from the logs (#4223)
b01ad14 
Since controller-runtime adds their own `reconcileID`, adding a uuid field
is not needed anymore.

Partially closes: #2206

Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
leonardoce pushed a commit that referenced this issue Apr 6, 2024
@sxd @leonardoce
chore: remove duplicate UUID from the logs (#4223)
0d4bc14 
Since controller-runtime adds their own `reconcileID`, adding a uuid field
is not needed anymore.

Partially closes: #2206

Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sxd sxd

Labels
None yet
Projects
CloudNativePG operator development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove the UUID from the logs cloudnative-pg/cloudnative-pg
3 participants
@mnencia @sxd @armru