Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scaling cooldown variables. #53

Merged
merged 6 commits into from Mar 5, 2024
Merged

Added scaling cooldown variables. #53

merged 6 commits into from Mar 5, 2024

Conversation

Jon-Berg
Copy link
Contributor

what

Added scaling cooldown variables.

why

Need to control autoscaling cooldown times to handle usage spikes.

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/appautoscaling_policy#target_tracking_scaling_policy_configuration

@Jon-Berg Jon-Berg requested review from a team as code owners June 27, 2023 17:11
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@hans-d hans-d added the stale This PR has gone stale label Mar 3, 2024
@hans-d
Copy link

hans-d commented Mar 3, 2024

@Jon-Berg Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness.

@hans-d
Copy link

hans-d commented Mar 3, 2024

/terratest

@hans-d
Copy link

hans-d commented Mar 3, 2024

README.md is outdated. Please run the following commands locally and push the file:
  make init
  make readme

@hans-d hans-d removed the stale This PR has gone stale label Mar 3, 2024
@hans-d hans-d self-assigned this Mar 3, 2024
@hans-d
Copy link

hans-d commented Mar 3, 2024

/terratest

hans-d
hans-d previously approved these changes Mar 3, 2024
@hans-d
Copy link

hans-d commented Mar 3, 2024

there seems to be some issue with the readme generation :-( as some bits seems to be flipping around. Letrs try if we can get lucky - as currently the merging is blocked because of that. WIll raise the readme issue internally.

@hans-d hans-d added the needs-cp label Mar 3, 2024
@hans-d
Copy link

hans-d commented Mar 4, 2024

The build harness that's being used is now updated to fix the flipping readme issues.

@hans-d
Copy link

hans-d commented Mar 4, 2024

@Jon-Berg can you update the readme once more?

@hans-d hans-d removed the needs-cp label Mar 4, 2024
@Jon-Berg
Copy link
Contributor Author

Jon-Berg commented Mar 5, 2024

@Jon-Berg can you update the readme once more?

I did but it doesn't seem to change anything

@joe-niland
Copy link
Sponsor Member

@Jon-Berg would you mind running terraform fmt also?

@hans-d
Copy link

hans-d commented Mar 5, 2024

/terratest

@hans-d hans-d enabled auto-merge (squash) March 5, 2024 09:55
@hans-d hans-d merged commit aad8f46 into cloudposse:main Mar 5, 2024
11 checks passed
@hans-d
Copy link

hans-d commented Mar 5, 2024

@Jon-Berg 🎉 Thanks for the ride !

@hans-d
Copy link

hans-d commented Mar 5, 2024

Looking into getting this released (seems also something 🐌 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants