added versioning mfa delete enabled option #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Withdrawing this PR for now, because it is not compatible with the lifecycle policy. They don't play well together and need to research how to fix it correctly. |
|
Figured out how to handle the lifecycle policy with the MFA delete enabled. Not sure if there are tests or something else that I missed for merging this. Please let me know and I'll get it fixed. |
nitrocode
previously approved these changes
Jun 4, 2021
|
/rebuild-readme |
|
/test all |
nitrocode
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This adds the option to turn on MFA Delete for the bucket.
why
issue #48 does a good job explaining, but pasted important information below
Security best practices for CloudTrail logs that are stored in S3 recommend MFA Delete be enabled.
https://www.cloudconformity.com/knowledge-base/aws/CloudTrail/cloudtrail-bucket-mfa-delete-enabled.html
references
closes #48