Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tflint terraform_comment_syntax #120

Closed
wants to merge 3 commits into from

Conversation

syphernl
Copy link

@syphernl syphernl commented Feb 2, 2021

what

  • Change inline comment from // to # per tflint results

why

  • tflint shows a warning about the way this comment is made

references

@syphernl syphernl requested a review from a team as a code owner February 2, 2021 07:58
Copy link
Sponsor Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @syphernl for pointing this out.

At the moment, releasing a new version of null-label is a major undertaking. @osterman @maximmi We should either do this immediately as 0.23.1 or wait and fold it into 0.24.0 (see #118). I prefer to wait, especially if we can get #118 finished and merged today.

If we are going to release this separately, then we need the version bump in context.tf

exports/context.tf Outdated Show resolved Hide resolved
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
@Nuru Nuru closed this in #121 Feb 4, 2021
@syphernl syphernl deleted the fix/tflint_comment branch February 4, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants