Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDP configurable payload #137

Open
momoXD007 opened this issue May 10, 2022 · 4 comments
Open

UDP configurable payload #137

momoXD007 opened this issue May 10, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@momoXD007
Copy link

The current version of the UDP prober sends the hardcoded payload "cloudprober".
However, in practice there are many applications UDP that will simply drop a packet like that, which basically means one has to change the application to make it "probable" with cloudprober.
The source code udp.go in lines 44 ff. even lists this inline as an open todo.

In my case it would help me with a set of applications that only answer udp probes if they contain specific payload. Without this change cloudprober is not an option to monitor these applications.

@momoXD007 momoXD007 added the enhancement New feature or request label May 10, 2022
@manugarg
Copy link
Contributor

Sure, this should be an easy change. I'll submit the fix soon.

@manugarg manugarg added this to the v0.11.8 milestone May 11, 2022
@manugarg
Copy link
Contributor

@momoXD007 and @tarrychk,

I probably spoke to too soon. We don't send a simple payload, but we send a message with payload. Message contains endpoints, timing data, and payload. If you just change the "inner payload", your UDP server will likely still not recognize the packet.

To give you some background, this probe was written primarily for detecting network issues. Cloudprober comes with a UDP server that this probe can work with: https://github.com/cloudprober/cloudprober/tree/master/servers/udp. This is what we did at my previous job (Google).

I was wondering what kind of apps you had in mind, and what kind of payloads do they expect. We may need another probe type to probe these apps. We may also try just modifying this probe, but getting more context from your side will help figure out the best way for this.

@manugarg manugarg removed this from the v0.11.8 milestone May 14, 2022
@manugarg
Copy link
Contributor

@momoXD007 wondering if you got a chance to look at my last message.

@momoXD007
Copy link
Author

momoXD007 commented May 19, 2022

One IPsec Gateway I saw, expects “Ping“ as payload for its UDP healthcheck and sends “Pong” back. A neat test to see if it works.

I imagine many applications that use UDP would implement a similar mechanism. But it is just an “educated guess”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants