Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please migrate from lib/pq to pgx #300

Closed
asuffield opened this issue Feb 28, 2023 · 2 comments
Closed

Please migrate from lib/pq to pgx #300

asuffield opened this issue Feb 28, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@asuffield
Copy link

https://github.com/cloudprober/cloudprober/blob/master/surfacers/postgres/postgres.go uses lib/pq, which is effectively abandoned in favour of https://github.com/jackc/pgx - should be a simple migration, just change the library and driver name passed to sql.Open.

@asuffield asuffield added the enhancement New feature or request label Feb 28, 2023
@manugarg
Copy link
Contributor

manugarg commented Mar 3, 2023

Thanks for filing this @asuffield. I started working on this here: #305. I think as a result of this, we'll probably end up restructuring postgres surfacer a bit, because pgx is not a drop-in replacement for pq.

@manugarg
Copy link
Contributor

This is done: #305.

@manugarg manugarg added this to the v0.13.5 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants