Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating metrics from HTTP probe output #356

Open
manugarg opened this issue Apr 20, 2023 · 2 comments
Open

Add support for creating metrics from HTTP probe output #356

manugarg opened this issue Apr 20, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@manugarg
Copy link
Contributor

I had opened ticket a long time back at the older location:
google/cloudprober#297

Recently while running a probe, I realized it can be quite a useful thing to be able to build metrics from HTTP probe's output.

@manugarg manugarg added the enhancement New feature or request label Apr 20, 2023
@manugarg
Copy link
Contributor Author

manugarg commented Sep 11, 2023

From the discussion on #508, I realized that we can probably go a step further and use HTTP headers for custom metrics as well. Something like:

output_metric_options {
  header_to_metrics {
    header: LastModified (LastModified | ContentLength)
    metric: last-modified
  }
  header_to_metrics {
    header: ContentLength
    metric: content-length
  }
  ...
}

@manugarg manugarg self-assigned this Sep 11, 2023
@manugarg
Copy link
Contributor Author

We can go a step further and provide an option generate metrics from JSON when output is JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant