Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload config file without restarting the pod #644

Open
syd20 opened this issue Dec 14, 2023 · 1 comment
Open

Reload config file without restarting the pod #644

syd20 opened this issue Dec 14, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@syd20
Copy link

syd20 commented Dec 14, 2023

To build upon feature request in #484, it would be helpful to have cloudprober read changes to the config file and update without the need to restart the pod. Currently I have a dynamic setup on EKS where I have multiple probes defined and changes to one requires me to regenerate the config file and then also restart the pod for the changes to take effect.

The option of using targets is not beneficial in this case but the underlying logic behind the targets file is what I would like to see for config files. With the option of reading from S3 scheduled for some upcoming release, it would be good to have a way where cloudprober reads the updated config and reloads (without a restart). Filebeat does something similar

@syd20 syd20 added the enhancement New feature or request label Dec 14, 2023
@manugarg manugarg self-assigned this Dec 17, 2023
@manugarg
Copy link
Contributor

Copying from what I said on #484...

Live reload has come up a few times before. I've been reluctant of adding it because clearing a probe's (and other) state cleanly on its removal was not very well implemented. We've certainly improved in that area quite a bit and can look at it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants