Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cmd to cmd/cloudprober for simplified install #690

Open
l2dy opened this issue Mar 7, 2024 · 1 comment
Open

Move cmd to cmd/cloudprober for simplified install #690

l2dy opened this issue Mar 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@l2dy
Copy link

l2dy commented Mar 7, 2024

Describe the feature you'd like and the problem it will solve

Currently the Getting Started guide gives 2 commands to install cloudprober and requires GOPATH, which is often not set in recent Go environments that uses Go modules.

go get github.com/cloudprober/cloudprober
GOBIN=$GOPATH/bin go install $GOPATH/src/github.com/cloudprober/cloudprober/cmd/cloudprober.go

I propose that we move cmd to cmd/cloudprober, so that the installation instructions can be simplified to

go install github.com/cloudprober/cloudprober/cmd/cloudprober@latest

and does not require the GOPATH environment variable anymore.

@l2dy l2dy added the enhancement New feature or request label Mar 7, 2024
@manugarg
Copy link
Contributor

manugarg commented Mar 8, 2024

Thanks @l2dy for reporting this. It makes sense but I'll need to change things in a bunch of places for this. I'll take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants