Fix client cert handling when cert reloading is enabled #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since cloudprober is the client, the dynamic cert loading needs to be implemented in GetClientCertificate rather than GetCertificate.
manugarg
approved these changes
Mar 14, 2024
|
No problem, sorry I didn't around to testing til now! |
|
This change breaks how certificate reloading works for grpc server, since in that context cloudprober is a server and it uses the same UpdateTLSConfig function that you changed 😢 |
|
#719 should add reloading behavior to server side certificates as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since cloudprober is the client, the dynamic cert loading needs to be implemented in GetClientCertificate rather than GetCertificate.