Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Github Plugin not returning repo custom properties #17907

Closed
1 of 2 tasks
duncanmapes opened this issue May 8, 2024 · 3 comments
Closed
1 of 2 tasks

bug: Github Plugin not returning repo custom properties #17907

duncanmapes opened this issue May 8, 2024 · 3 comments

Comments

@duncanmapes
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

a column is being created in the repo table, but no values are being set

Expected Behavior

the custom property values on the repo are expected to be set

CloudQuery (redacted) config

n/a

Steps To Reproduce

No response

CloudQuery (redacted) logs

n/a

CloudQuery version

v5.18.1

Additional Context

No response

Pull request (optional)

  • I can submit a pull request
@candiduslynx
Copy link
Contributor

I wonder if that's only returned on get request rather than list one.

@erezrokah
Copy link
Contributor

I wonder if that's only returned on get request rather than list one.

💯 This is correct based on the list vs get schema in https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#list-organization-repositories vs https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#get-a-repository

@erezrokah
Copy link
Contributor

erezrokah commented May 8, 2024

Somewhat related to google/go-github#3159 (misalignment between the Go SDK response object and the rest API response schema)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants