fix: Managed writer log message, timeout->flush #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark resultsComparing with 5ffad03
|
disq
approved these changes
Dec 28, 2022
yevgenypats
approved these changes
Dec 29, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 1, 2023
🤖 I have created a release *beep* *boop* --- ## [1.16.1](v1.16.0...v1.16.1) (2023-01-01) ### Bug Fixes * **deps:** Update golang.org/x/exp digest to 738e83a ([#546](#546)) ([bdf3ff1](bdf3ff1)) * **deps:** Update google.golang.org/genproto digest to f9683d7 ([#552](#552)) ([763d22b](763d22b)) * **deps:** Update module github.com/getsentry/sentry-go to v0.16.0 ([#549](#549)) ([b4a0efc](b4a0efc)) * **deps:** Update module github.com/inconshreveable/mousetrap to v1.1.0 ([#555](#555)) ([f449234](f449234)) * **deps:** Update module github.com/mattn/go-isatty to v0.0.17 ([#553](#553)) ([826006f](826006f)) * **deps:** Update module github.com/schollz/progressbar/v3 to v3.12.2 ([#547](#547)) ([b6640b8](b6640b8)) * **deps:** Update module github.com/thoas/go-funk to v0.9.3 ([#548](#548)) ([6e5469a](6e5469a)) * **deps:** Update module golang.org/x/net to v0.4.0 ([#550](#550)) ([9ced5ec](9ced5ec)) * **deps:** Update module golang.org/x/text to v0.5.0 ([#551](#551)) ([1353026](1353026)) * Managed writer log message, timeout->flush ([#536](#536)) ([6b0c711](6b0c711)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the log message to reflect the correct case
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)