Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

.NET Core support #97

Open
viktorklang opened this issue Sep 11, 2019 · 10 comments
Open

.NET Core support #97

viktorklang opened this issue Sep 11, 2019 · 10 comments
Labels
EPIC Indicates that this Issue is a large undertaking and will require splitting into smaller sub-issues. user platform Issues related to the different user target platforms

Comments

@viktorklang
Copy link
Contributor

It would be really cool to support .NET Core for user functions!

@viktorklang viktorklang added user platform Issues related to the different user target platforms EPIC Indicates that this Issue is a large undertaking and will require splitting into smaller sub-issues. labels Sep 11, 2019
@ghost
Copy link

ghost commented Oct 4, 2019

I've ported some of Lagom to NETcore in the past (nagytech/lagom-dotnet) so I'm keen to help with a NETcore implementation of CloudState.

But, I've run into a few minor issues so far. First, I've had to to dig into the NETCore gRpc implementation. The current Google.Protobuf library they use protects the reflective Descriptor classes. When I get to a point where it will build and I'm not embarrassed about the code, I'll check it in for some review.

@viktorklang
Copy link
Contributor Author

@nagytech Very cool, this will be very interesting! Let us know if you have any questions, the gitter channel is typically a good place to ask questions.

@ghost
Copy link

ghost commented Oct 26, 2019

I've added my implementation here: https://github.com/nagytech/cloudstate-csharp/

But, as mentioned earlier I still need to resolve the issues in the csharp libraries for Protobuf and gRPC. One of them will need to wait for Protobuf 3.11.0: protocolbuffers/protobuf#5441

Additionally, there is an outstanding issue in VSCode that makes developing gRPC quite difficult:

In the meantime, I'm going to refine and document what I've created.

@viktorklang
Copy link
Contributor Author

@nagytech Cool, I'll have a look!

@sleipnir
Copy link
Contributor

sleipnir commented Feb 4, 2020

I believe that this can be merged with an official repository on cloudstate github account. I did a review with Jonathan that resulted in this minor issue, but I believe that everything else is fit.

@sleipnir
Copy link
Contributor

sleipnir commented Feb 4, 2020

The issue is not related to TCK testing features so it should not impact anyone using this library.

@sleipnir
Copy link
Contributor

sleipnir commented Feb 4, 2020

The issue is not related to TCK testing features so it should not impact anyone using this library.

but I still sent a PR https://github.com/nagytech/cloudstate-csharp/pull/7

@viktorklang
Copy link
Contributor Author

@sleipnir @nagytech Created this: https://github.com/cloudstateio/dotnet-support prepare PR?

@ghost
Copy link

ghost commented Feb 6, 2020

Thanks @viktorklang. I'll send one through in the next day or so.

@viktorklang
Copy link
Contributor Author

Perfect, thanks @nagytech!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
EPIC Indicates that this Issue is a large undertaking and will require splitting into smaller sub-issues. user platform Issues related to the different user target platforms
Projects
None yet
Development

No branches or pull requests

2 participants