Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtcp-fb inconsistent #17

Open
clux opened this issue Jan 18, 2014 · 1 comment
Open

rtcp-fb inconsistent #17

clux opened this issue Jan 18, 2014 · 1 comment
Labels

Comments

@clux
Copy link
Owner

clux commented Jan 18, 2014

trr-int is currently labelled as a push attribute, meaning it can be more than one per media stream, but this seems unlikely from reading rfc4585.

also, trr-int basically pass the normal rtcp-fb regex, maybe just join them?

@clux clux added the question label Oct 31, 2014
@Saku2
Copy link

Saku2 commented Mar 18, 2020

rtcpFb is defined as a single object in the type definitions. This causes a crash as the writer code tries to iterate over it because it is labelled as push.

Could you either turn the 'push' to 'name' as the original issue suggests, or change the type definition to an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants