Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use proper token definition in regexes #56

Open
clux opened this issue Feb 20, 2017 · 1 comment
Open

use proper token definition in regexes #56

clux opened this issue Feb 20, 2017 · 1 comment

Comments

@clux
Copy link
Owner

clux commented Feb 20, 2017

In many places we use (\w*) or less commonly (.*) as a shorthand for what rfc4566's definition of a token:

   token-char =          %x21 / %x23-27 / %x2A-2B / %x2D-2E / %x30-39
                         / %x41-5A / %x5E-7E

   token =               1*(token-char)

worth going through and making this conform to the standard where it references token as it would make the library more resilient against future updates to various identifiers undoubtedly introduced in the future.

First seen in #53 ( pr #54 )

clux added a commit that referenced this issue Feb 20, 2017
@clux
Copy link
Owner Author

clux commented Feb 20, 2017

think i found another one:

a=rtpmap:107 vnd.onvif.metadata/90000

parses as invalid in the coverage.test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant