Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas for future versions #72

Open
7 of 21 tasks
cmfcmf opened this issue Apr 12, 2016 · 4 comments
Open
7 of 21 tasks

Ideas for future versions #72

cmfcmf opened this issue Apr 12, 2016 · 4 comments

Comments

@cmfcmf
Copy link
Owner

cmfcmf commented Apr 12, 2016

Cleanup and Minor Features

  • Remove deprecated methods and constructor arguments from the OpenWeatherMap class
  • Change ° C back to °C (The API should not be HTML aware.)
  • Add better error handling
  • Make sure to handle invalid data from OWM properly (Invalid argument supplied for foreach() in WeatherForecast.php on line 85 #100)
  • getRawWeatherGroupData() #131
  • Remove population field from City.
  • Remove $appid from all methods except constructor
  • Split forecast apis into two methods (no more magic depending on the number of requested days)
  • Rename temperature->current to temperature->avg
  • Split up Temperature class into separate class for 16 day forecast
  • Merge getCurrentWeather() and getCurrentWeatherGroup()

Documentation

Tests

  • Achieve 100% test code coverage
    • Find a tool to create a mock api server
    • Integrate mock api server

New Features


You are welcome to propose further (backwards incompatible) changes.

@aseriy
Copy link
Contributor

aseriy commented Apr 12, 2016

Achieve 100% test code coverage?

@peter279k
Copy link
Contributor

Hi @aseriy , the code coverage is very closed to the 100%.
Please refer this PR. Thanks.

@peter279k
Copy link
Contributor

The official OpenWeather API service now supports the air pollution service.
Is it possible to add this feature in the next version?

Thanks.

@cmfcmf
Copy link
Owner Author

cmfcmf commented Feb 1, 2017

Is it possible to add this feature in the next version?

It certainly is possible to add this feature. However, I currently do not have the time to do so. I'd gladly accept contributions though :)

This was referenced May 29, 2019
@cmfcmf cmfcmf changed the title Ideas for version 3 Ideas for future versions Jun 9, 2019
@cmfcmf cmfcmf pinned this issue Jun 9, 2019
@cmfcmf cmfcmf removed this from the 3.0.0 milestone Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants