Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version missing #880

Open
adavidzh opened this issue Dec 14, 2023 · 2 comments
Open

Version missing #880

adavidzh opened this issue Dec 14, 2023 · 2 comments

Comments

@adavidzh
Copy link
Member

I just tried the docker image (because CAT-23-001) and I was surprised positively that there is now a cute heading when running the tool:

[cmsusr@a1bfab4ca9ff code]$ combine
 <<< Combine >>>
Missing datacard file
Usage: combine [options]
Use combine --help to get a list of all the allowed methods and options

OTOH, taking the perspective of a software user, it is kind of weird that there is no version information, neither in the header, nor as a command line option:

[cmsusr@a1bfab4ca9ff code]$ combine --help | grep ersion
[cmsusr@a1bfab4ca9ff code]$

I think this can be a real pain to deal with support requests.

Should the version be compiled into the code in order to embed it into printouts and perhaps even ROOT file outputs ("This result brought to you by combine vX.Y.Z")?

@nucleosynthesis
Copy link
Contributor

Fixed with ce02748

@kcormi
Copy link
Collaborator

kcormi commented Dec 14, 2023

One thing which might be a good idea is somehow automatically syncing between the version the code prints out and the tags, so that we don't rely on always remembering to do both.

I think it could be done with the highest answer as giving here: https://stackoverflow.com/questions/33481173/is-there-a-way-to-make-git-auto-generate-a-version-number-file-for-a-version-o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants