Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup lepton selection codes #1195

Open
simonepigazzini opened this issue Jan 23, 2020 · 1 comment
Open

Cleanup lepton selection codes #1195

simonepigazzini opened this issue Jan 23, 2020 · 1 comment
Labels
analysis-leptons Analysis issue related to electrons or muons cleanup

Comments

@simonepigazzini
Copy link
Contributor

At the moment there are two libraries related to lepton selections:

https://github.com/cms-analysis/flashgg/blob/dev_legacy_runII/Taggers/src/LeptonSelection.cc

https://github.com/cms-analysis/flashgg/blob/dev_legacy_runII/Taggers/src/LeptonSelection2018.cc

@sam-may @edjtscott @mhl0116 @fabio-mon please take a look at this. If the 2018 labeled file is used for all three years now please remove the old one an update the taggers accordingly, otherwise we should diversify the function in a better why.

Thank you,

simone

@simonepigazzini simonepigazzini added cleanup analysis-leptons Analysis issue related to electrons or muons labels Jan 23, 2020
@fabio-mon
Copy link
Contributor

Hello,
in the two libraries there are 2 functions with the same name, i.e., 'selectMuons' and 'selectElectrons'. However, comparing them, the selections differ for some aspect (see below). My proposal is to merge the two libraries in Leptonselection.cc, changing the name of one pair of functions.

  • selectMuons:

    • LeptonSelection.cc : the vertex is manually selected as the one which minimizes deltaZ(mu,vtx). This vertex is used to require a minimum deltaZ(mu,trk) and to determine if the muon is tight
    • LeptonSelection2018.cc : The 0-th vertex is used to determine if the muon is tight and no request on deltaZ(mu,vtx) are applied.
  • selectElectrons:

  • LeptonSelection.cc : the vertex is manually selected as the one which minimizes deltaZ(ele,vtx). This vertex is used to require a minimum deltaZ and deltaXY (mu,trk). The photon veto and the isolation are also explicitly applied.

  • LeptonSelection2018.cc : the method passMVALooseId() (or medium/tight) is used to select the corresponding electrons. No selections on deltaXY or deltaZ (ele,trk) are applied. The photon veto and the isolation are not required (maybe it is applied in a previous/further part of the sequence?).

Ciao,
Fabio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis-leptons Analysis issue related to electrons or muons cleanup
Projects
None yet
Development

No branches or pull requests

2 participants