Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark functions called by WorkerInPath::runWorkerAsync() as noexcept #44881

Closed
makortel opened this issue May 1, 2024 · 9 comments
Closed

Mark functions called by WorkerInPath::runWorkerAsync() as noexcept #44881

makortel opened this issue May 1, 2024 · 9 comments

Comments

@makortel
Copy link
Contributor

makortel commented May 1, 2024

Spinoff from https://github.com/cms-sw/cmssw/pull/44767/files#r1586330343

This would be mostly relevant for all the *Async() functions called from there. We could do one pass to add the noexcept, that would help to identify problematic places, and another pass to carefully evaluate how to fix any of the problems found.

@makortel
Copy link
Contributor Author

makortel commented May 1, 2024

assign core

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2024

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2024

A new Issue was created by @makortel.

@sextonkennedy, @smuzaffar, @antoniovilela, @Dr15Jones, @rappoccio, @makortel can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented May 9, 2024

From the review of #44902, a few functions that should be checked next

  • ESSourceProductResolverBase::prefetchAsyncImplTemplate()
  • NoProcessProductResolver::tryPrefetchResolverAsync()
  • Principal:: getProductResolverByIndex() (probably just mark it as noexcept)

@Dr15Jones
Copy link
Contributor

From the review of #44902, a few functions that should be checked next

See #44902

@makortel
Copy link
Contributor Author

Done in #44902 and #44950

@makortel
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants