Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register FastMonitoringService as concrete type to Service system #44942

Open
Dr15Jones opened this issue May 9, 2024 · 6 comments
Open

Register FastMonitoringService as concrete type to Service system #44942

Dr15Jones opened this issue May 9, 2024 · 6 comments

Comments

@Dr15Jones
Copy link
Contributor

Everywhere that request the MicroStateService from edm::Service eventually does a C++ cast to FastMonitoringService*. It would be much better to just register the service as FastMonitoringService instead of as the base class.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2024

A new Issue was created by @Dr15Jones.

@smuzaffar, @antoniovilela, @Dr15Jones, @makortel, @sextonkennedy, @rappoccio can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

assign EventFilter/Utilities

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2024

New categories assigned: daq

@emeschi,@smorovic you have been requested to review this Pull request/Issue and eventually sign? Thanks

@Dr15Jones
Copy link
Contributor Author

The MicroStateService class is empty (i.e. no member function or member data). That entire class should just go away.

Or much, much better MicroStateService should gain abstract virtual functions for all the methods modules use from FastMonitoringService and then all module should just talk through those virtual methods. Then FastMonitoringService should move to the plugins directory. This would allow FWCore/ActivityRegistry dependency to be dropped from EventFilters/Utilities which would decrease our overall physical dependencies in or libraries.

@smorovic
Copy link
Contributor

smorovic commented May 9, 2024

Agreed, MicroStateService is legacy class that should be dropped, so we will prepare these changes.
To drop FWCore/ActivityRegistry dependency, I assume that we also need to move EvFDaqDirector to plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants