Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Edit this page" links no longer working #637

Open
krumware opened this issue Apr 25, 2024 · 3 comments · Fixed by #639
Open

"Edit this page" links no longer working #637

krumware opened this issue Apr 25, 2024 · 3 comments · Fixed by #639
Labels
website Related to TAG website.

Comments

@krumware
Copy link
Collaborator

The "Edit this page" links are no longer working, likely due to some of the recent restructure.

Steps to replicate:

  1. Navigate to any page on the Tag App Delivery website.
  2. Click "Edit this page"
  3. Results in a 404 on github

image

image

@abangser
Copy link
Collaborator

I wonder if this was caused by the work in #625 (FYI - @lianmakesthings) and/or if @cjyabraham has seen something like this before?

@abangser abangser added the website Related to TAG website. label Apr 28, 2024
@lianmakesthings
Copy link
Collaborator

lianmakesthings commented Apr 28, 2024

I think this is due to the multi-language support, as the content is now under content/language code/filename, but the link points to content/filename
I suspect this will require a bigger fix that we'd really need to think about, as we are also duplicating some pages into other languages etc.

@lianmakesthings
Copy link
Collaborator

From #639

The problem is, the duplicated page itself doesn't know it's duplicated. I didn't want to make it too complex, that's why the duplication happens during build, and not before.
I'm thinking about what the expected behaviour should be for those cases. The issue happens, when I'm on a non-default language page that has been duplicated. So if I'm clicking edit, do I want to add a translation or do I want to edit the English page? I'd argue both are likely expectations, so it's tough to say what the fix should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Related to TAG website.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants