Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline ConsoleInteraction.nothing_done() #4523

Open
Makman2 opened this issue Jul 22, 2017 · 12 comments · May be fixed by #6169
Open

Inline ConsoleInteraction.nothing_done() #4523

Makman2 opened this issue Jul 22, 2017 · 12 comments · May be fixed by #6169
Assignees
@roshnet
Labels
area/tests difficulty/newcomer type/codestyle

Comments

@Makman2
Copy link
Member

Makman2 commented Jul 22, 2017

It's only used once, has a bad name and then we also don't need a specific test for it.
@sitharaPN-space
Copy link

i found the location where it has been mentioned. so do i need to remove the test case or what i can do to fix this.?

@SanketDG
Copy link
Member

@aasiya13 Since nothing_done() has no advantages in being a function, we remove it and instead just use it inline where it is called, so basically copy the contents of the function to where its called and remove the original declaration

@chitranshi21
Copy link

please review the pull request for this issue .

#4558

@chitranshi21
Copy link

Hi,

Can you assign the issue to me. I have submitted a patch already.

@Makman2
Copy link
Member Author

Makman2 commented Jul 28, 2017

Please ask and get assigned before you start working on an issue to avoid duplicated work. It seems that @aasiya13 had no time recently to start anyway, but please settle that before doing an issue 👍

@sitharaPN-space
Copy link

it's okay. i had tough time last days. i'm really sorry for the inconvenience..

@Makman2
Copy link
Member Author

Makman2 commented Jul 30, 2017

@aasiya13 sure don't worry :D no inconvenience was caused by you ;)

@chitranshi21
Copy link

Hey @Makman2 Can you assign this issue to me now..?

@Makman2
Copy link
Member Author

Makman2 commented Jul 30, 2017

You haven't accepted the invitation from us yet, we can't assign you before 👍

@chitranshi21
Copy link

done ..!! please assign me now .

@SanketDG
Copy link
Member

SanketDG commented Aug 3, 2017

@chitranshi21 you are assigned.

On a side note, you can also assign it yourself, https://api.coala.io/en/latest/Developers/Newcomers_Guide.html#step-2-picking-up-an-issue

@roshnet
Copy link
Member

roshnet commented Mar 17, 2019

Hi. I see that this issue still persists. I would like to be assigned to it.

@li-boxuan li-boxuan assigned roshnet and unassigned chitranshi21 Mar 30, 2019
roshnet added a commit to roshnet/coala that referenced this issue Apr 4, 2019
@roshnet
ConsoleInteraction: Remove nothing_done()
75e279c 
Replace occurrences of nothing_done() with it's definition.

Fixes coala#4523
@roshnet roshnet mentioned this issue Apr 4, 2019
Open
@PrasanthChettri PrasanthChettri linked a pull request Jun 3, 2021 that will close this issue
Open
2 tasks
PrasanthChettri added a commit to PrasanthChettri/coala that referenced this issue Jun 5, 2021
@PrasanthChettri
ConsoleInteraction.py : removed nothing_done() function
036109b 
Removed nothing_done() method in ConsoleInteraction and added it inline where it's called.
Accommodated the code with consequent code changes, eg : deleted tests for the method

Fixes coala#4523
PrasanthChettri added a commit to PrasanthChettri/coala that referenced this issue Jun 5, 2021
@PrasanthChettri
ConsoleInteraction: Replace nothing_done() inline
fa8299c 
Removed nothing_done() and added it inline where it's called and
deleted tests for the method.

Fixes coala#4523
PrasanthChettri added a commit to PrasanthChettri/coala that referenced this issue Jun 7, 2021
@PrasanthChettri
ConsoleInteraction: Replace nothing_done() inline
de4b71f 
Removed nothing_done() and added it inline where it's called and
deleted tests for the method.

Closes coala#4523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roshnet roshnet

Labels
area/tests difficulty/newcomer type/codestyle
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ConsoleInteraction: Replace nothing_done() inline PrasanthChettri/coala
6 participants
@Makman2 @chitranshi21 @SanketDG @gitmate-bot @sitharaPN-space @roshnet