Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: allow checking for element enabled/disabled status #544

Open
ncoghlan opened this issue May 29, 2017 · 3 comments
Open

RFE: allow checking for element enabled/disabled status #544

ncoghlan opened this issue May 29, 2017 · 3 comments
Milestone

Comments

@ncoghlan
Copy link

For a test case I'm currently working on [1], the only way I found to check for an element's enabled/disabled status is to query the private _element attribute directly:

find_by_id_result.first._element.is_enabled

Would it be reasonable to add an API equivalent to the existing one for visible that instead checked the enabled status of the underlying component? (I have a partially prepared patch for this, but I'm having trouble running the test suite locally on Fedora, so it isn't complete yet, and I figured it made sense to ask if the idea was acceptable in principle before continuing to work on it)

[1] https://github.com/leapp-to/prototype/pull/139/files

@andrewsmedina
Copy link
Member

I'm +1 for this feature. @ncoghlan a PR is welcome.

If you need help, let me know

@ncoghlan
Copy link
Author

@andrewsmedina I'll file a separate issue with the test failures I'm getting running the test suite on Fedora 25. My assumption is that I'm missing some things from my environment, but I'm not familiar enough with splinter's internals yet to understand what they might be.

@ncoghlan
Copy link
Author

#545 covers that test failures I'm seeing. Some of them are clearly related to web drivers that I don't have configured, but some of the others are significantly less clear as to what is going wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants