Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] Update to graphql-js 16 #498

Open
Powersource opened this issue Jan 3, 2022 · 4 comments
Open

[DEV] Update to graphql-js 16 #498

Powersource opened this issue Jan 3, 2022 · 4 comments

Comments

@Powersource
Copy link
Member

I tried this and I got a ton of errors that told me

error - Error: graphql@16 dropped long-deprecated support for positional arguments, please pass an object instead.

Related links

graphql/graphql-js#2904
graphql/graphql-js#2301
https://github.com/graphql/graphql-js/releases/tag/v16.0.0

It sounds like they're basically enforcing this previous best practice? https://graphql-rules.com/rules/mutation-input-arg Which would be a relatively big change.

This isn't very urgent to do yet but urql seems to have added support for this version already so I guess we'll have to do this eventually.

@Powersource
Copy link
Member Author

Feeling a bit more unsure what exactly they mean is deprecated 🤔 Could be arguments in resolvers as well?

@aerugo
Copy link
Contributor

aerugo commented Mar 13, 2022

This feels like something we should pay some attention to.
@gustavlrsn - what do you think?

@aerugo aerugo changed the title Update to graphql-js 16 [DEV] Update to graphql-js 16 Mar 13, 2022
@Powersource
Copy link
Member Author

@aerugo i don't think he checks his email notifs, better to contact on discord

@aerugo
Copy link
Contributor

aerugo commented Mar 14, 2022

I've made the Discord integration work now, so maybe @gustavlrsn will see it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants