Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: collation using pg_catalog.default does not work #123939

Open
fqazi opened this issue May 10, 2024 · 2 comments
Open

sql: collation using pg_catalog.default does not work #123939

fqazi opened this issue May 10, 2024 · 2 comments
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Originated from a customer P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@fqazi
Copy link
Collaborator

fqazi commented May 10, 2024

Currently CRDB does not support the builtin collation pg_catalog.default, which makes it incompatible with PostgresSQL. For example we support the following:

select 'a' < ('foo' COLLATE default);

but on Postgres the following is valid syntax as well.

select 'a' < ('foo' COLLATE pg_catalog.default);

Jira issue: CRDB-38613

Epic CRDB-37763

@fqazi fqazi added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-pgcompat Semantic compatibility with PostgreSQL T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels May 10, 2024
@blathers-crl blathers-crl bot added this to Triage in SQL Foundations May 10, 2024
@rafiss
Copy link
Collaborator

rafiss commented May 14, 2024

We might need to update the syntax rule for collation names here:

collation_name: unrestricted_name

@exalate-issue-sync exalate-issue-sync bot added O-support Originated from a customer P-2 Issues/test failures with a fix SLA of 3 months labels May 14, 2024
@marksoper
Copy link

Also part of the original customer feedback: the original SQL that was not working was generated by the \d <table_or_view_name> command. So the customer is not just saying "hey this SQL doesn't work", but also "why does the describe command produce SQL that doesn't work".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Originated from a customer P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Foundations
  
Triage
Development

No branches or pull requests

3 participants