Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: add a timeseries metric for SST count by compression algorithm #123952

Open
Tracked by #123950
nicktrav opened this issue May 10, 2024 · 0 comments
Open
Tracked by #123950

storage: add a timeseries metric for SST count by compression algorithm #123952

nicktrav opened this issue May 10, 2024 · 0 comments
Assignees
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team
Projects

Comments

@nicktrav
Copy link
Collaborator

nicktrav commented May 10, 2024

Expose a timeseries metric that will allow us to slice the SSTable count by compression algorithm (snappy vs zstd).

Jira issue: CRDB-38624

@nicktrav nicktrav added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-storage Relating to our storage engine (Pebble) on-disk storage. T-storage Storage Team labels May 10, 2024
@blathers-crl blathers-crl bot added this to Incoming in Storage May 10, 2024
@nicktrav nicktrav moved this from Incoming to Next in Storage May 14, 2024
@nicktrav nicktrav assigned nicktrav and itsbilal and unassigned nicktrav May 14, 2024
itsbilal added a commit to itsbilal/pebble that referenced this issue May 15, 2024
Previously, we didn't have a metric tracking the compression type(s)
of sstables. This change adds that, as a table stat that's collected
through the LevelMetadata as an annotator field. This unfortunately
had to be a table stat as the compression type isn't known until
we open a reader and look at the properties block.

Pebble side of cockroachdb/cockroach#123952.
itsbilal added a commit to itsbilal/pebble that referenced this issue May 15, 2024
Previously, we didn't have a metric tracking the compression type(s)
of sstables. This change adds that, as a table stat that's collected
through the LevelMetadata as an annotator field. This unfortunately
had to be a table stat as the compression type isn't known until
we open a reader and look at the properties block.

Pebble side of cockroachdb/cockroach#123952.
nicktrav pushed a commit to itsbilal/pebble that referenced this issue May 17, 2024
Previously, we didn't have a metric tracking the compression type(s)
of sstables. This change adds that, as a table stat that's collected
through the LevelMetadata as an annotator field. This unfortunately
had to be a table stat as the compression type isn't known until
we open a reader and look at the properties block.

Pebble side of cockroachdb/cockroach#123952.
nicktrav pushed a commit to cockroachdb/pebble that referenced this issue May 17, 2024
Previously, we didn't have a metric tracking the compression type(s)
of sstables. This change adds that, as a table stat that's collected
through the LevelMetadata as an annotator field. This unfortunately
had to be a table stat as the compression type isn't known until
we open a reader and look at the properties block.

Pebble side of cockroachdb/cockroach#123952.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team
Projects
Storage
  
Next
Development

No branches or pull requests

2 participants