Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: unredacted debug zip query for transaction_contention_events table too slow #123964

Open
xinhaoz opened this issue May 10, 2024 · 0 comments
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-observability

Comments

@xinhaoz
Copy link
Member

xinhaoz commented May 10, 2024

#118478 aimed to add the query texts for transactions in crdb_internal.transaction_contention_events to the debug zip. We've seen this query timeout for clusters experiencing a lot of contention. The join collecting the blocking transaction's query strings results in a full scan of the system.statement_statistics table and should be removed. We can investigate other options or queries that may preserve some of this information.

Update May 16:
We'll do 3 things to improve upon what was added:

  1. Increase default timeout - a couple of of other queries (e.g. cluster locks table) are also timing out, so we should just increaes the default itmeout. Note that there's also a CLI flag for users to set this.
  2. Include a fallback query in addition to the one that was added above that includes the non-expensive information
  3. Improve runtime of the added query by using the index on statement fingerprint id (we'll have to join on the txn stats table to accomplish this)

Jira issue: CRDB-38628

@xinhaoz xinhaoz added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label May 10, 2024
@xinhaoz xinhaoz self-assigned this May 10, 2024
@xinhaoz xinhaoz changed the title cli: unredacted debug zip for transaction_contention_events table too slow cli: unredacted debug zip query for transaction_contention_events table too slow May 10, 2024
@exalate-issue-sync exalate-issue-sync bot changed the title cli: unredacted debug zip query for transaction_contention_events table too slow cli: unredacted debug zip for transaction_contention_events table too slow May 10, 2024
@exalate-issue-sync exalate-issue-sync bot changed the title cli: unredacted debug zip for transaction_contention_events table too slow cli: unredacted debug zip query for transaction_contention_events table too slow May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-observability
Projects
None yet
Development

No branches or pull requests

1 participant