Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fcmOptions #3

Open
mathieu21 opened this issue Sep 8, 2020 · 7 comments
Open

Add support for fcmOptions #3

mathieu21 opened this issue Sep 8, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mathieu21
Copy link

Add support for fcmOptions: https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages#AndroidFcmOptions

Including Analytics labels used to filter data in Firebase

@williamdes williamdes added the enhancement New feature or request label Sep 8, 2020
@williamdes williamdes modified the milestones: 1.5.0, 1.6.0 Sep 8, 2020
williamdes added a commit that referenced this issue Nov 24, 2020
@williamdes williamdes self-assigned this Nov 24, 2020
@williamdes
Copy link
Member

Hi @mathieu21
Could you test this before a release is done ?

@yaroslavsnisarua
Copy link

When send Push with analyticsLabel, it not shown at Firebase Chart.

@williamdes williamdes reopened this Jun 16, 2021
@williamdes williamdes modified the milestones: 1.6.0, 1.6.3 Nov 13, 2021
@williamdes
Copy link
Member

See: ToothlessGear/node-gcm#340 (comment)

Indeed this parameter is not supported in the FCM Legacy HTTP Server API.

So we need to migrate to V1 API, see #9

cc @mathieu21

@quocthi2005
Copy link

Hi @williamdes
How to add analyticsLabel to the message?
Firebase has a feature to set this.
https://firebase.google.com/docs/cloud-messaging/understand-delivery#adding-analytics-labels-to-messages

How to set this in this package?

@williamdes
Copy link
Member

Hi!

we need to migrate to V1 API, see #9

The current API does not take the analytics label in account. So we need to migrate to the new API.
Do you want to help?

@quocthi2005
Copy link

Thank you @williamdes

Do you want to help?

Yes, it's great

@williamdes
Copy link
Member

Thank you @williamdes

Do you want to help?

Yes, it's great

Feel free to send pull-requests

@williamdes williamdes modified the milestones: 1.8.0, 1.9.0 Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

4 participants