-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n #6
Comments
Hi, |
Sure! The actual line: https://github.com/moment/moment/blob/develop/moment.js#L947 Cheers! |
Yes, I think I saw that when I was looking over the moment.js code - it's close to what I would need, but doesn't quite cover everything. There is no string for '1 second' (the closest is 'a few seconds') and also the singular phrases for minutes, hours etc all use 'a' or 'an' rather than '1' - I think it would look odd if the plugin produced output that was a mixture, like '2 hours a minute 3 seconds' rather than '2 hours 1 minute 3 seconds' |
Would be nice to make it very configurable for this kind of things |
👍 for this. |
👍 |
3 similar comments
👍 |
👍 |
👍 |
I have added a |
@codebox it's a pity you can't reuse
What if you suggest to add |
@IvanRF you mean like this? moment/moment#4183 |
can someone tell me if there is a solution about this issue ? I'm trying to translate the result of
to french but I don't find how to do it... Every thread refer to #6 but I don't see any tips about it :( I "found' those lines in the moment-precise-range.js :
helas, I have no idea how to overide it |
@borisBelloc probably best you can do is to call |
thanks for the fast answer 👍 👍 |
I wrote in Turkish, but this code will work.
|
Hi!
I would like to use your library with internationalization so I was digging the code
Did you notice that moment by itself has the strings your code needs to make the precise range?
Would be nice to make a deeper integration with the dependency and it will gain automatic translation
Are you interested on this issue?
Thanks!!!
The text was updated successfully, but these errors were encountered: