Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude structure and/or duplication engines from engine:install when explicitly disabled #935

Open
nextrevision opened this issue Jan 14, 2020 · 0 comments · May be fixed by #936
Open
Assignees

Comments

@nextrevision
Copy link

I've disabled the structure and duplication plugins in my .codeclimate.yml file, however when running codeclimate engines:install those two plugins are still installed. The egines:install command should not pull engine images that are disabled explicitly and will not be used.

.codeclimate.yml

version: "2"
plugins:
  structure:
    enabled: false
  duplication:
    enabled: false
  checkstyle:
    enabled: true
    config: './checkstyle.xml'
$ docker images codeclimate/*
REPOSITORY                TAG                 IMAGE ID            CREATED             SIZE
codeclimate/codeclimate   latest              d2fbd39cfd1a        5 days ago          127MB
codeclimate/codeclimate   0.85.6              12ee53c30164        8 weeks ago         111MB
$ codeclimate engines:install
...docker image pull output...
$ docker images codeclimate/*
REPOSITORY                            TAG                 IMAGE ID            CREATED             SIZE
codeclimate/codeclimate               latest              d2fbd39cfd1a        5 days ago          127MB
codeclimate/codeclimate-checkstyle    latest              fec8cdafcfac        8 days ago          394MB
codeclimate/codeclimate               0.85.6              12ee53c30164        8 weeks ago         111MB
codeclimate/codeclimate-structure     latest              79763c9b6233        4 months ago        5.16GB
codeclimate/codeclimate-duplication   latest              984fb1d1bb1f        4 months ago        5.16GB
@nextrevision nextrevision linked a pull request Jan 14, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants