Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error during upload doesn't fail action #1337

Open
tobiasdiez opened this issue Mar 21, 2024 · 2 comments
Open

Error during upload doesn't fail action #1337

tobiasdiez opened this issue Mar 21, 2024 · 2 comments
Assignees

Comments

@tobiasdiez
Copy link

The action fails with the messages

 warning - 2024-03-21 14:32:57,088 -- No config file could be found. Ignoring config.
Error: Codecov token not found. Please provide Codecov token with -t flag.
Warning: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

but the step is actually shown as "successful" in the github interface. It would be good to actually fail in case there is an error.

Example: https://github.com/apollo-server-integrations/apollo-server-integration-h3/actions/runs/8376730386/job/22937079972?pr=51

@dwisiswant0
Copy link

Just enable the fail_ci_if_error option, coz by default it is false.

@tomage
Copy link

tomage commented Apr 16, 2024

This is a bad default, I would opt for changing it to true, or inverting the flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants