Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail_ci_if_error should default to true #1348

Open
JoshuaKGoldberg opened this issue Mar 30, 2024 · 0 comments
Open

fail_ci_if_error should default to true #1348

JoshuaKGoldberg opened this issue Mar 30, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@JoshuaKGoldberg
Copy link

Splitting out of discussion in #1293: right now, if a repository uses v4 of the action without a CODECOV_TOKEN, their build will fail to upload coverage data but still ✅ pass. The logs will look something like this (example run):

==> Uploader SHASUM verified (e3ea28a069fe174eb99ac2ffb523bfb55d5d29a7cfd93ef48cde12e9b552b492  codecov)
info - 2024-03-29 13:16:58,766 -- ci service found: github-actions
warning - 2024-03-29 13:16:58,778 -- No config file could be found. Ignoring config.
Error: Codecov token not found. Please provide Codecov token with -t flag.
Warning: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

The action not failing on an explicit Error: is surprising behavior. If an action fails to do its express purpose, you'd expect it to fail.

Furthermore, many repositories automatically create dependency update PRs for GitHub actions. Even if they're not automatically merged, it's easy to miss in the three error/warning lines that one of them is new and actually matters now.

Separately from requests to re-allow tokenless uploading, could you please change fail_ci_if_error's default from false to true in a new major version, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants