Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create commit fails after too many retries when upgrading to codecov-action v4 #1369

Open
jmgrady opened this issue Apr 10, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@jmgrady
Copy link

jmgrady commented Apr 10, 2024

When upgrading from v3.1.4 to v4.x.x we are seeing that the report upload is failing. The required token is being passed to the action and it works on v3. The full output is at https://github.com/sillsdev/TheCombine/actions/runs/8632978671/job/23665019290?pr=3003

The traceback shows:

Traceback (most recent call last):
  File "codecov_cli/main.py", line 81, in <module>
  File "codecov_cli/main.py", line 77, in run
  File "click/core.py", line 1157, in __call__
  File "click/core.py", line 1078, in main
  File "click/core.py", line 1688, in invoke
  File "click/core.py", line 1434, in invoke
  File "click/core.py", line 783, in invoke
  File "click/decorators.py", line 33, in new_func
  File "codecov_cli/commands/commit.py", line 64, in create_commit
  File "codecov_cli/services/commit/__init__.py", line 28, in create_commit_logic
  File "codecov_cli/services/commit/__init__.py", line 64, in send_commit_data
  File "codecov_cli/helpers/request.py", line 78, in wrapper
Exception: Request failed after too many retries
[2095] Failed to execute script 'main' due to unhandled exception!
@rohan-at-sentry
Copy link
Contributor

rohan-at-sentry commented Apr 15, 2024

@thomasrockhu-codecov can you take a look?

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Apr 16, 2024
@thomasrockhu-codecov thomasrockhu-codecov added the bug Something isn't working label Apr 16, 2024
@thomasrockhu-codecov thomasrockhu-codecov removed their assignment Apr 16, 2024
@thomasrockhu-codecov
Copy link
Contributor

Can probably take a look, but may be better for someone on the CLI team

@rohan-at-sentry
Copy link
Contributor

@jmgrady it's possible that this coincided towards the end of our degraded performance incident on the 9th of April. Would you mind re-running and reporting if this is still a problem?

@rohan-at-sentry rohan-at-sentry removed their assignment May 1, 2024
@jmgrady
Copy link
Author

jmgrady commented May 1, 2024

jmgrady it's possible that this coincided towards the end of our degraded performance incident on the 9th of April. Would you mind re-running and reporting if this is still a problem?

@rohan-at-sentry,

The problem remains for our project.

Here is the output from the upload attempt: https://github.com/sillsdev/TheCombine/actions/runs/8912800071/job/24477037957

You can see the GitHub workflow at https://github.com/sillsdev/TheCombine/blob/codecov-action-v4/.github/workflows/backend.yml

Thank you for your help. Let me know if there is any more information that you need.

@rohan-at-sentry
Copy link
Contributor

We'll take a look with engineering. Thanks for raising!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants