Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: codecov/codecov-node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.7.1
Choose a base ref
...
head repository: codecov/codecov-node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.7.2
Choose a head ref
  • 9 commits
  • 5 files changed
  • 3 contributors

Commits on Jul 21, 2020

  1. Recover broken find pattern for UNIX (again) 

    ref: #184
continuous from: yhatt@ada583b

#180 makes `find` command change to run through
`execFileSync()`. However, it always returns empty result because of
the quote has over-included as the filename of search condition. So
removed quotes from generated conditions.

In addition, removing brackets from find arguments (a4cc565) has
affected to the result of finding coverage files. This commit reverts
brackets to get back the original search condition too.

Previously quotes and escaped-brackets are required to run command on
the shell environment, but no longer need them because of using
`execFileSync()` that is disabled shell environment by default.
    @yhatt
    yhatt committed Jul 21, 2020
    Copy the full SHA
    e3ff6ce View commit details

Commits on Jul 22, 2020

  1. See if codecov works without file descriptor

    @thomasrockhu
    thomasrockhu committed Jul 22, 2020
    Copy the full SHA
    29b4998 View commit details

  2. Update network logic

    @thomasrockhu
    thomasrockhu committed Jul 22, 2020
    Copy the full SHA
    0b72631 View commit details

  3. Force a commit

    @thomasrockhu
    thomasrockhu committed Jul 22, 2020
    Copy the full SHA
    7a74556 View commit details

  4. Trigger

    @thomasrockhu
    thomasrockhu committed Jul 22, 2020
    Copy the full SHA
    537ae90 View commit details

  5. Merge pull request #185 from yhatt/recover-failing-to-read-file 

    Recover broken find pattern for UNIX
    @thomasrockhu
    thomasrockhu authored Jul 22, 2020
    Copy the full SHA
    7c8f19e View commit details

  6. Bump to 3.7.2

    @thomasrockhu
    thomasrockhu committed Jul 22, 2020
    Copy the full SHA
    45be882 View commit details

  7. Bump package-lock

    @thomasrockhu
    thomasrockhu committed Jul 22, 2020
    Copy the full SHA
    8d91837 View commit details

  8. Merge pull request #186 from codecov/3.7.2 

    Bump to 3.7.2
    @thomasrockhu
    thomasrockhu authored Jul 22, 2020
    Copy the full SHA
    6d88cf4 View commit details
Showing with 72 additions and 68 deletions.
  1. +1 −0 .travis.yml
  2. +4 −4 README.md
  3. +65 −62 lib/codecov.js
  4. +1 −1 package-lock.json
  5. +1 −1 package.json
1 change: 1 addition & 0 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -13,3 +13,4 @@ node_js:

after_success:
- ./bin/codecov -e TRAVIS_NODE_VERSION -f coverage/*.json
- ./bin/codecov -e TRAVIS_NODE_VERSION
8 changes: 4 additions & 4 deletions README.md
View file
Original file line number Diff line number Diff line change
@@ -89,8 +89,7 @@ nyc report --reporter=text-lcov > coverage.lcov

## Troubleshooting

If you're seeing an **HTTP 400 error when uploading reports to S3**, make sure you've updated to at least version 3.7.0.

If you're seeing an **HTTP 400 error when uploading reports to S3**, make sure you've updated to at least version 3.7.0.

## Change Log

@@ -116,5 +115,6 @@ If you're seeing an **HTTP 400 error when uploading reports to S3**, make sure y
- v3.6.3 Fix for AWS Codebuild & package updates
- v3.6.4 Fix Cirrus CI
- v3.7.0 Remove the X-Amz-Acl: public-read header

.
- v3.7.1 Move to execFileSync and security fixes
- v3.7.2 Fix issue with network and file finding
.
127 changes: 65 additions & 62 deletions lib/codecov.js
View file
Original file line number Diff line number Diff line change
@@ -20,64 +20,66 @@ var isWindows =

if (!isWindows) {
patterns = (
"-type f -name '*coverage.*' " +
"-or -name 'nosetests.xml' " +
"-or -name 'jacoco*.xml' " +
"-or -name 'clover.xml' " +
"-or -name 'report.xml' " +
"-or -name 'cobertura.xml' " +
"-or -name 'luacov.report.out' " +
"-or -name 'lcov.info' " +
"-or -name '*.lcov' " +
"-or -name 'gcov.info' " +
"-or -name '*.gcov' " +
"-or -name '*.lst' " +
"-not -name '*.sh' " +
"-not -name '*.data' " +
"-not -name '*.py' " +
"-not -name '*.class' " +
"-not -name '*.xcconfig' " +
"-not -name 'Coverage.profdata' " +
"-not -name 'phpunit-code-coverage.xml' " +
"-not -name 'coverage.serialized' " +
"-not -name '*.pyc' " +
"-not -name '*.cfg' " +
"-not -name '*.egg' " +
"-not -name '*.whl' " +
"-not -name '*.html' " +
"-not -name '*.js' " +
"-not -name '*.cpp' " +
"-not -name 'coverage.jade' " +
"-not -name 'include.lst' " +
"-not -name 'inputFiles.lst' " +
"-not -name 'createdFiles.lst' " +
"-not -name 'coverage.html' " +
"-not -name 'scoverage.measurements.*' " +
"-not -name 'test_*_coverage.txt' " +
"-not -path '*/vendor/*' " +
"-not -path '*/htmlcov/*' " +
"-not -path '*/home/cainus/*' " +
"-not -path '*/virtualenv/*' " +
"-not -path '*/js/generated/coverage/*' " +
"-not -path '*/.virtualenv/*' " +
"-not -path '*/virtualenvs/*' " +
"-not -path '*/.virtualenvs/*' " +
"-not -path '*/.env/*' " +
"-not -path '*/.envs/*' " +
"-not -path '*/env/*' " +
"-not -path '*/envs/*' " +
"-not -path '*/.venv/*' " +
"-not -path '*/.venvs/*' " +
"-not -path '*/venv/*' " +
"-not -path '*/venvs/*' " +
"-not -path '*/.git/*' " +
"-not -path '*/.hg/*' " +
"-not -path '*/.tox/*' " +
"-not -path '*/__pycache__/*' " +
"-not -path '*/.egg-info*' " +
"-not -path '*/$bower_components/*' " +
"-not -path '*/node_modules/*' " +
"-not -path '*/conftest_*.c.gcov'"
'-type f ( ' +
'-name *coverage.* ' +
'-or -name nosetests.xml ' +
'-or -name jacoco*.xml ' +
'-or -name clover.xml ' +
'-or -name report.xml ' +
'-or -name cobertura.xml ' +
'-or -name luacov.report.out ' +
'-or -name lcov.info ' +
'-or -name *.lcov ' +
'-or -name gcov.info ' +
'-or -name *.gcov ' +
'-or -name *.lst ' +
') ' +
'-not -name *.sh ' +
'-not -name *.data ' +
'-not -name *.py ' +
'-not -name *.class ' +
'-not -name *.xcconfig ' +
'-not -name Coverage.profdata ' +
'-not -name phpunit-code-coverage.xml ' +
'-not -name coverage.serialized ' +
'-not -name *.pyc ' +
'-not -name *.cfg ' +
'-not -name *.egg ' +
'-not -name *.whl ' +
'-not -name *.html ' +
'-not -name *.js ' +
'-not -name *.cpp ' +
'-not -name coverage.jade ' +
'-not -name include.lst ' +
'-not -name inputFiles.lst ' +
'-not -name createdFiles.lst ' +
'-not -name coverage.html ' +
'-not -name scoverage.measurements.* ' +
'-not -name test_*_coverage.txt ' +
'-not -path */vendor/* ' +
'-not -path */htmlcov/* ' +
'-not -path */home/cainus/* ' +
'-not -path */virtualenv/* ' +
'-not -path */js/generated/coverage/* ' +
'-not -path */.virtualenv/* ' +
'-not -path */virtualenvs/* ' +
'-not -path */.virtualenvs/* ' +
'-not -path */.env/* ' +
'-not -path */.envs/* ' +
'-not -path */env/* ' +
'-not -path */envs/* ' +
'-not -path */.venv/* ' +
'-not -path */.venvs/* ' +
'-not -path */venv/* ' +
'-not -path */venvs/* ' +
'-not -path */.git/* ' +
'-not -path */.hg/* ' +
'-not -path */.tox/* ' +
'-not -path */__pycache__/* ' +
'-not -path */.egg-info* ' +
'-not -path */$bower_components/* ' +
'-not -path */node_modules/* ' +
'-not -path */conftest_*.c.gcov'
).split(' ')
} else {
winPatterns = (
@@ -358,10 +360,11 @@ var upload = function(args, on_success, on_failure) {
var root = path.resolve(args.options.root || query.root || '.')
console.log('==> Building file structure')
try {
upload +=
execFileSync('git', ['ls-files', '||', 'hg', 'locate'], { cwd: root })
.toString()
.trim() + '\n<<<<<< network\n'
var network = execFileSync('git', ['ls-files'], { cwd: root })
if (network === '') {
network = execFileSync('hg', ['locate'], { cwd: root })
}
upload += network.toString().trim() + '\n<<<<<< network\n'
} catch (err) {
// not a git/hg dir, emulating git/hg ignore behavior
upload +=
2 changes: 1 addition & 1 deletion package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "codecov",
"version": "3.7.0",
"version": "3.7.2",
"description": "Uploading report to Codecov: https://codecov.io",
"main": "index.js",
"scripts": {