Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more checks on elapsed time in test_wait.go #136

Open
ryan-gang opened this issue Feb 29, 2024 · 1 comment
Open

Add more checks on elapsed time in test_wait.go #136

ryan-gang opened this issue Feb 29, 2024 · 1 comment
Assignees

Comments

@ryan-gang
Copy link
Contributor

Currently we don't check the time elapsed when the WAIT command is supposed to return early.
But, as highlighted by @andy1li, this might lead to cases where user never implements WAIT properly, just sleeps for time_duration, and returns.

This can be mitigated by adding checks on elapsed_time in cases where WAIT returns early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant