Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedbacks should be written on the specific file #8

Open
cloud26 opened this issue Jul 24, 2023 · 2 comments
Open

Feedbacks should be written on the specific file #8

cloud26 opened this issue Jul 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@cloud26
Copy link
Contributor

cloud26 commented Jul 24, 2023

The specific comments for the file should be written on the file itself, not as general comments for the entire PR.
@Arcadia822 Arcadia822 added the enhancement New feature or request label Aug 12, 2023
@Arcadia822
Copy link
Member

If write on file, is it a must solved comment thread instead of a common comment?

@cloud26
Copy link
Contributor Author

cloud26 commented Aug 15, 2023

If write on file, is it a must solved comment thread instead of a common comment?

It depends on the project settings that whether the comment should be closed before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cloud26 @Arcadia822