Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to nrwl 13 #1247

Closed
webberwang opened this issue Jan 4, 2022 · 1 comment · Fixed by #1263
Closed

Upgrade to nrwl 13 #1247

webberwang opened this issue Jan 4, 2022 · 1 comment · Fixed by #1263
Assignees
@webberwang

Comments

@webberwang
Copy link
Member

webberwang commented Jan 4, 2022 •
edited

Since webpack less compile has issue with nextjs in nrwl 13, which uses webpack 5. we have compiled the less to CSS file & import directly.

Use branch https://github.com/codelab-ai/codelab.ai/tree/1247-nrwl-13

If you can figure out how to integrate LESS compilation with webpack 5 that would be great.
@phmngocnghia phmngocnghia self-assigned this Jan 4, 2022
phmngocnghia added a commit that referenced this issue Jan 5, 2022
@phmngocnghia
feat(apps): #1247 upgrade nwrl to 13
a311529 
upgrade nwrl to 13

CLOSES: #1247
@phmngocnghia phmngocnghia mentioned this issue Jan 5, 2022
Closed
webberwang pushed a commit that referenced this issue Jan 6, 2022
@phmngocnghia
feat(apps): #1247 upgrade nwrl to 13
1aa5071 
upgrade nwrl to 13

CLOSES: #1247
webberwang pushed a commit that referenced this issue Jan 10, 2022
@phmngocnghia
feat(apps): #1247 upgrade nwrl to 13
2d0a0ce 
upgrade nwrl to 13

CLOSES: #1247
@antonmihaylov
Copy link
Contributor

antonmihaylov commented Jan 10, 2022 •
edited

Issues to keep track of for migrating to Next 12 and SWC
vercel/next.js#30804
nrwl/nx#7602 - SWC is mentioned in the roadmap of NX 14
ben-rogerson/twin.macro#516

phmngocnghia added a commit that referenced this issue Jan 11, 2022
@phmngocnghia
feat(apps): #1247 upgrade nwrl to 13
05e9b5b 
upgrade nwrl to 13

CLOSES: #1247
phmngocnghia added a commit that referenced this issue Jan 11, 2022
@phmngocnghia
build(apps): #1247 downgrade next to 12
4c6defa 
upgrade nwrl to 13
CLOSES: #1247

CLOSES: #1247
webberwang pushed a commit that referenced this issue Jan 11, 2022
@phmngocnghia
feat(apps): #1247 upgrade nwrl to 13
2271ddd 
upgrade nwrl to 13

CLOSES: #1247
webberwang pushed a commit that referenced this issue Jan 11, 2022
@phmngocnghia
build(apps): #1247 downgrade next to 12
2bb71cd 
upgrade nwrl to 13
CLOSES: #1247

CLOSES: #1247
phmngocnghia added a commit that referenced this issue Jan 11, 2022
@phmngocnghia
build(apps): #1247 downgrade next to 11
09d889e 
upgrade nwrl to 13
CLOSES: #1247

CLOSES: #1247
phmngocnghia added a commit that referenced this issue Jan 11, 2022
@phmngocnghia
build(apps): #1247 clean up code
b24da4c 
CLOSES: #1247
phmngocnghia added a commit that referenced this issue Jan 11, 2022
@phmngocnghia
fix(apps): #1247 fix test
c42d407 
CLOSES: #1247
phmngocnghia added a commit that referenced this issue Jan 11, 2022
@phmngocnghia
fix(apps): #1247 fix test
716fafb 
CLOSES: #1247
phmngocnghia added a commit that referenced this issue Jan 11, 2022
@phmngocnghia
fix(apps): #1247 lint
a3eceb7 
CLOSES: #1247
@webberwang webberwang mentioned this issue Jan 11, 2022
Merged
phmngocnghia added a commit that referenced this issue Jan 13, 2022
@phmngocnghia
fix(apps): #1247 fix buttons: Create atom,lambda,Export atom
ea39e9a 
CLOSES: #1262
phmngocnghia added a commit that referenced this issue Jan 13, 2022
@phmngocnghia
fix(apps): #1247 fix buttons: Create atom,lambda,Export atom
613fff3
phmngocnghia added a commit that referenced this issue Jan 17, 2022
@phmngocnghia
fix(apps): #1247 fix buttons: Create atom,lambda,Export atom
a13967b
webberwang pushed a commit that referenced this issue Jan 17, 2022
@phmngocnghia
fix(apps): #1247 fix buttons: Create atom,lambda,Export atom (#1276)
1400e6e
webberwang pushed a commit that referenced this issue Oct 19, 2022
@phmngocnghia
fix(apps): #1247 fix buttons: Create atom,lambda,Export atom (#1276)
86393b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webberwang webberwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1247 nrwl 13 upgrade codelab-app/platform
1247 nrwl 13 codelab-app/platform
3 participants
@webberwang @phmngocnghia @antonmihaylov