Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use autocorrect and autocapitalize value of on instead of empty string #7010

Merged
merged 1 commit into from Dec 9, 2022
Merged

Use autocorrect and autocapitalize value of on instead of empty string #7010

merged 1 commit into from Dec 9, 2022

Conversation

josephdpurcell
Copy link
Contributor

Fixes #7009 and ultimately should fix directus/directus#16690.

@josephdpurcell
Copy link
Contributor Author

Correction: this doesn't actually fix the issue... see #7009 (comment).

@josephdpurcell
Copy link
Contributor Author

Even though this doesn't fix the issue, based on the iOS docs the values should be on instead of "" (empty string), which is addressed by this PR. I did not check to see historical compatibility with older browsers or even cross compatibility with other browsers.

@marijnh marijnh merged commit d4d7d3c into codemirror:master Dec 9, 2022
@marijnh marijnh mentioned this pull request Dec 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@josephdpurcell @marijnh