Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ability to execute tests with/without isolation between tests #2054

Closed
wants to merge 5 commits into from

Conversation

JrmyDev
Copy link
Contributor

@JrmyDev JrmyDev commented Mar 8, 2017

No description provided.

It was impossible to execute TestRunner with cleanMode = false. So if cleanMode must be false by default so we can use both.
@JrmyDev JrmyDev changed the title z fixed ability to execute tests with/without isolation between tests Mar 8, 2017
@JrmyDev
Copy link
Contributor Author

JrmyDev commented Mar 8, 2017

Sorry this pull request contains some invalid commits

@JrmyDev JrmyDev closed this Mar 8, 2017
@JrmyDev JrmyDev reopened this Mar 8, 2017
@JrmyDev
Copy link
Contributor Author

JrmyDev commented Mar 8, 2017

Can you merge just the commit with the fix please

@codenameone
Copy link
Collaborator

If I understood this correctly this is a patch for one line flipping a boolean value from true to false?
Are there other changes? It's hard to see with the merges.

@JrmyDev
Copy link
Contributor Author

JrmyDev commented Mar 8, 2017

Yes that it. No there no other changes. Sorry I'm not so familiar with github. Actually, I just want to pull request "fix attribute cleanMode in TestRunner" commit ...

@codenameone
Copy link
Collaborator

Github is a bit of a problem. Not sure how it got this way but the merge seems to be messed up a bit.
I'm not sure that's the right thing to do though, that flag is there to provide test isolation which is important otherwise one test can impact the result of another. Offering an option to toggle it might be OK e.g. thru a flag in codenameone_settings.properties.

@JrmyDev
Copy link
Contributor Author

JrmyDev commented Mar 9, 2017

I agree with you. But actually, you can't execute tests without isolation with this code !!
As your test mecanism mix both unit and functionnal tests, we may want execute some tests together.
TestRunner class provide attribute for such use case but we can't switch it (I mean, if you pass cleanMode=false as parameter of TestRunner class, in build.xml -do-test-run task, it does nothing)

@codenameone
Copy link
Collaborator

So the correct fix would be to fix that, no?

@JrmyDev
Copy link
Contributor Author

JrmyDev commented Mar 9, 2017

Yes it is !
I will try to fix in that way ...

@JrmyDev
Copy link
Contributor Author

JrmyDev commented Mar 9, 2017

After reflexion, I think it should be better to accept my commit, and edit yourbuild.xmlfile to add cleanMode argument by default. That way, we could be able to execute without cleanMode (removing arg in build.xml file).

@codenameone
Copy link
Collaborator

That would take some work. Changing the build.xml means going thru a plugin update cycle and doing it for the 3 IDE's. Not trivial.

JrmyDev added a commit to JrmyDev/CodenameOne that referenced this pull request Mar 16, 2017
JrmyDev added a commit to JrmyDev/CodenameOne that referenced this pull request Mar 16, 2017
@JrmyDev JrmyDev closed this Mar 16, 2017
@shai-almog
Copy link
Collaborator

@all-contributors please add @JrmyDev for code

@allcontributors
Copy link
Contributor

@shai-almog

I've put up a pull request to add @JrmyDev! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants