Use password in URL to login similar as in jupyter notebook servers #6734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Thank you for the PR!
I think we should do this on the backend rather than relying on automatically filling the form on the frontend.
If the password is in the query parameters, then we check it, if it matches then we set the cookie. We could also redirect to strip out the session_password query variable so it does not persist in the URL (otherwise someone could potentially read it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6733
This change allows passing the password in the URL to code-server to allow automatic login similar to the token in jupyter notebook servers.
We can use the following snippet to create the URL and launch code-server.
Clicking on this link printed to the terminal by the above code will login the user to code-server without any interaction.
http://mycomputer.com:8080/login?session_password=fbf7cc58bbd90a9f172490f5c57201e03ca967efe424090c872b3218110f29fa