Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace ACL's to allow sharing akin to template permissions page #13225

Open
2 tasks
Emyrk opened this issue May 10, 2024 · 2 comments
Open
2 tasks

Workspace ACL's to allow sharing akin to template permissions page #13225

Emyrk opened this issue May 10, 2024 · 2 comments
Assignees
Labels
feature Something we don't have yet

Comments

@Emyrk
Copy link
Member

Emyrk commented May 10, 2024

Workspace Sharing

Just like templates, add ACL lists to workspaces to enable sharing. Sharing works to groups + users.

Backend

  • Database + api work to add ACLs to workspaces

Frontend

  • Permissions UI page for workspace for sharing to groups + other users
@Emyrk Emyrk added this to the RBAC Upgrades -- Project Rabbit milestone May 10, 2024
@coder-labeler coder-labeler bot added the feature Something we don't have yet label May 10, 2024
@ammario
Copy link
Member

ammario commented May 15, 2024

We should hold off on completing this until we have strong alignment on how to correctly do shared infrastructure. For example, @bpmct and I discussed Group-owned workspaces that everyone in a Group has access to. The benefit of that model is there are no user-specific credentials injected into the workspace at start.

A bad case is we have multiple paths in the product to achieve the same user story and no clear guidance to our users and when to use which.

@Emyrk
Copy link
Member Author

Emyrk commented May 15, 2024

@ammario at present we assume workspaces are owned by some user, and like you said we inject user credentials.

Moving to a group owned model, a lot of that code has to have branches. And scripts inside a workspace will need to have branches to accommodate missing env vars or w/e.

I would like to investigate the use cases for group owned workspaces. Peer development can be accomplished via extensions like VSCode LiveShare. If group owned workspaces are intended for some sort of ownerless environment like CI, it feels like a "CI" headless user could exist.

Just my 2c

@Emyrk Emyrk removed this from the RBAC Upgrades milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something we don't have yet
Projects
None yet
Development

No branches or pull requests

2 participants