Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Duration strings instead of seconds when we accept timeouts / intervals #117

Open
ammario opened this issue Mar 28, 2023 · 2 comments
Open

Use Duration strings instead of seconds when we accept timeouts / intervals #117

ammario opened this issue Mar 28, 2023 · 2 comments
Milestone
v1 — breaking

Comments

@ammario
Copy link
Member

ammario commented Mar 28, 2023

E.g., in coder_app and coder_agent.metadata.
@ammario ammario added this to the v1 — breaking milestone Mar 28, 2023
@ammario ammario mentioned this issue Mar 28, 2023
Merged
10 tasks
@ammario ammario changed the title Use Duration strings instead of seconds when we accept timeouts Use Duration strings instead of seconds when we accept timeouts / intervals Mar 28, 2023
@matifali
Copy link
Contributor

Something like?
1m30s instead of 90?

@ammario
Copy link
Member Author

ammario commented Jun 28, 2023

Yes, exactly. It's not clear what the unit is otherwise.

It's also painful to write automated tests when the interval is 1s. It takes many seconds to get a significant sample size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1 — breaking
Development

No branches or pull requests
2 participants
@ammario @matifali